chore: use standard #661
chore: use standard #661
Conversation
This way it won't get run for every appraisal. We'll run it separately via Lefthook in dev and a separate workflow in CI.
Rakefile:15: warning: rdoc/task was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.
This reverts commit df81fa3.
|
@mperham where were you seeing Ruby 2.3 builds happening? Our test matrix starts at 3.0: https://github.com/honeybadger-io/honeybadger-ruby/blob/master/.github/workflows/ruby.yml#L17 We can remove 3.0 and (soon) 3.1 though, since they are EOL: https://www.ruby-lang.org/en/downloads/branches/ cc @stympy |
|
I was only speaking of the required Ruby version in the gemspec. I saw 2.3 but realized I couldn't go anywhere near that far back to test. |
Ah, right. @stympy I think we should update the gemspec before merging this so that we can use more modern operators (I think we may have already been using some?). |
|
@stympy JRuby is a tricky beast, it might make sense to update the matrix in a separate issue 😁 |
Integrate the Standard linter into the build.
I've included both safe and unsafe automated fixes but I did not make any manual code changes. Please run
bundle exec rake standardto see the list of lint warnings.I also included a .standard.yml with ruby 2.3.0 as the minimum version. If you bump this, it will use newer language features. Unfortunately my local rubies are mostly horked so I could only test Ruby 3.3.